Re: [Mesa-dev] [PATCH 1/9] glsl: Consolidate ir_expression constructors that use explicit types.

2013-02-26 Thread Kenneth Graunke
On 02/19/2013 05:03 PM, Matt Turner wrote: From: Kenneth Graunke kenn...@whitecape.org Previously, we had separate constructors for one, two, and four operand expressions. This patch consolidates them into a single constructor which uses NULL default parameters. The unary and binary operator

Re: [Mesa-dev] [PATCH 1/9] glsl: Consolidate ir_expression constructors that use explicit types.

2013-02-20 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: From: Kenneth Graunke kenn...@whitecape.org Previously, we had separate constructors for one, two, and four operand expressions. This patch consolidates them into a single constructor which uses NULL default parameters. The unary and binary operator

Re: [Mesa-dev] [PATCH 1/9] glsl: Consolidate ir_expression constructors that use explicit types.

2013-02-20 Thread Paul Berry
On 20 February 2013 12:25, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: From: Kenneth Graunke kenn...@whitecape.org Previously, we had separate constructors for one, two, and four operand expressions. This patch consolidates them into a single constructor

Re: [Mesa-dev] [PATCH 1/9] glsl: Consolidate ir_expression constructors that use explicit types.

2013-02-20 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: On 20 February 2013 12:25, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: From: Kenneth Graunke kenn...@whitecape.org Previously, we had separate constructors for one, two, and four operand expressions. This patch

[Mesa-dev] [PATCH 1/9] glsl: Consolidate ir_expression constructors that use explicit types.

2013-02-19 Thread Matt Turner
From: Kenneth Graunke kenn...@whitecape.org Previously, we had separate constructors for one, two, and four operand expressions. This patch consolidates them into a single constructor which uses NULL default parameters. The unary and binary operator constructors had assertions to verify that