Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-21 Thread Emil Velikov
On 20 October 2015 at 05:08, Matt Turner wrote: > Otherwise we'd emit a MOV from the null register (which isn't allowed). > Would you say it's a good idea to push the check down to the MOV() implementation ? If not perhaps we should add an assert() to easily catch cases like

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-21 Thread Matt Turner
On Wed, Oct 21, 2015 at 1:52 PM, Emil Velikov wrote: > On 20 October 2015 at 05:08, Matt Turner wrote: >> Otherwise we'd emit a MOV from the null register (which isn't allowed). >> > Would you say it's a good idea to push the check down to the MOV()

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-20 Thread Iago Toral
On Mon, 2015-10-19 at 21:08 -0700, Matt Turner wrote: > Otherwise we'd emit a MOV from the null register (which isn't allowed). > > Helps 24 programs in shader-db (the geometry shaders in GSCloth): > > instructions in affected programs: 302 -> 262 (-13.25%) Makes sense to me, Reviewed-by:

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 1:01 AM, Iago Toral wrote: > On Mon, 2015-10-19 at 21:08 -0700, Matt Turner wrote: >> Otherwise we'd emit a MOV from the null register (which isn't allowed). >> >> Helps 24 programs in shader-db (the geometry shaders in GSCloth): >> >> instructions in

[Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-19 Thread Matt Turner
Otherwise we'd emit a MOV from the null register (which isn't allowed). Helps 24 programs in shader-db (the geometry shaders in GSCloth): instructions in affected programs: 302 -> 262 (-13.25%) --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp| 18 +-