Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

The problem was that it declared SVIEW but llvmpipe didn't like that for some reason. Marek On Oct 8, 2015 5:12 AM, "Roland Scheidegger" wrote: > Am 08.10.2015 um 02:02 schrieb Marek Olšák: > > Hi Brian, > > > > This is the commit that broke DrawPixels on llvmpipe, but not

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Was that because stencil used sampler 1 but sview 0 which looks definitely wrong as there needs o be a 1:1 mapping between these when the tex opcodes are used? Roland Am 08.10.2015 um 10:45 schrieb Marek Olšák: > The problem was that it declared SVIEW but llvmpipe didn't like that for > some

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On 10/07/2015 06:02 PM, Marek Olšák wrote: Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Thanks. That fixes the conform and piglit regressions. For the series, Reviewed-by: Brian Paul

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Am 08.10.2015 um 16:46 schrieb Marek Olšák: > > On Oct 8, 2015 4:03 PM, "Roland Scheidegger" > wrote: >> >> Was that because stencil used sampler 1 but sview 0 which looks >> definitely wrong as there needs o be a 1:1 mapping between these when >>

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On Oct 8, 2015 4:03 PM, "Roland Scheidegger" wrote: > > Was that because stencil used sampler 1 but sview 0 which looks > definitely wrong as there needs o be a 1:1 mapping between these when > the tex opcodes are used? I don't remember how the SVIEW declarations work. It was

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Am 08.10.2015 um 02:02 schrieb Marek Olšák: > Hi Brian, > > This is the commit that broke DrawPixels on llvmpipe, but not radeonsi > and softpipe. It's fixed in v2, which is attached. > > Marek > > On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: >> From: Marek Olšák

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Marek On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: > From: Marek Olšák > > - there is no connection to user fragment

[Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

From: Marek Olšák - there is no connection to user fragment shaders, so having these as shader variants makes no sense - don't use Mesa IR, use TGSI - don't create gl_fragment_program, just create the shader CSO --- src/mesa/state_tracker/st_cb_drawpixels.c | 185