Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-08-08 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > On Mon, 2016-08-08 at 16:12 +0200, Juan A. Suarez Romero wrote: >> Hmm... what about the case of exec_size == 4 and writing just a >> float?  >> >> I understand in this case we only should mark one word, so the loop >> should  not be

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-08-08 Thread Juan A. Suarez Romero
On Mon, 2016-08-08 at 16:12 +0200, Juan A. Suarez Romero wrote: > Hmm... what about the case of exec_size == 4 and writing just a > float?  > > I understand in this case we only should mark one word, so the loop > should  not be 2*inst->regs_written. > > Note that in the original patch that was

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-08-08 Thread Juan A. Suarez Romero
On Fri, 2016-07-29 at 12:59 -0700, Francisco Jerez wrote: > |   for (unsigned i = 0; i < 2 * inst->regs_written; i++) > { > |  for (int c = 0; c < 4; c++) > | result_live[c] |= BITSET_TEST( > |    live, var_from_reg(alloc,

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-08-01 Thread Juan A. Suarez Romero
On Fri, 2016-07-29 at 12:59 -0700, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > > > From: "Juan A. Suarez Romero" > > > > Our current data flow analysis does not take into account that > > channels > > on 64-bit operands are 64-bit. This is

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-07-29 Thread Francisco Jerez
Iago Toral Quiroga writes: > From: "Juan A. Suarez Romero" > > Our current data flow analysis does not take into account that channels > on 64-bit operands are 64-bit. This is a problem when the same register > is accessed using both 64-bit and 32-bit

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-07-26 Thread Iago Toral
This patch should not be so early in the series. It uses the execsize information in the IR which is not available until patch 38, so it should really go after that. Iago On Tue, 2016-07-19 at 12:40 +0200, Iago Toral Quiroga wrote: > From: "Juan A. Suarez Romero" > > Our

[Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-07-19 Thread Iago Toral Quiroga
From: "Juan A. Suarez Romero" Our current data flow analysis does not take into account that channels on 64-bit operands are 64-bit. This is a problem when the same register is accessed using both 64-bit and 32-bit channels. This is very common in operations where we need to