Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-23 Thread Ian Romanick
On 07/21/2014 03:17 PM, Matt Turner wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: +enum glsl_matrix_layout { + GLSL_MATRIX_LAYOUT_DEFAULT, Does this mean language-default, or does it really means the inherited layout? E.g., for layout(row_major)

[Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ast_to_hir.cpp| 8 +++-- src/glsl/builtin_types.cpp | 74 +- src/glsl/builtin_variables.cpp | 2 +- src/glsl/glsl_types.cpp|

Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: +enum glsl_matrix_layout { + GLSL_MATRIX_LAYOUT_DEFAULT, Does this mean language-default, or does it really means the inherited layout? E.g., for layout(row_major) uniform a { mat4 m; }; m's .matrix_layout is

Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 3:17 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: +enum glsl_matrix_layout { + GLSL_MATRIX_LAYOUT_DEFAULT, Does this mean language-default, or does it really means the inherited layout? E.g., for