Re: [Mesa-dev] [PATCH 11/25] mesa/i965/i915/r200: eliminate gl_vertex_program

2016-10-18 Thread Timothy Arceri
On Tue, 2016-10-18 at 12:07 -0700, Ian Romanick wrote: > I'd like to see two tiny changes: > > 1. A comment for the IsPositionInvariant field that it can only be > true > for vertex programs. I already had that this is only used for assembly style vertex programs. I've reworded it to be only

Re: [Mesa-dev] [PATCH 11/25] mesa/i965/i915/r200: eliminate gl_vertex_program

2016-10-18 Thread Ian Romanick
I'd like to see two tiny changes: 1. A comment for the IsPositionInvariant field that it can only be true for vertex programs. 2. An assertion or two like assert(p->Target == GL_VERTEX_PROGRAM_ARB || !p->IsPositionInvariant); in reasonable places. I'm thinking: - Where

[Mesa-dev] [PATCH 11/25] mesa/i965/i915/r200: eliminate gl_vertex_program

2016-10-18 Thread Timothy Arceri
Here we move the only field in gl_vertex_program to the ARB program fields in gl_program. --- src/mesa/drivers/common/meta.c | 10 +-- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/dri/i915/i915_fragprog.c| 4 +-