Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-03 Thread Pohjolainen, Topi
On Thu, Sep 01, 2016 at 08:28:38AM -0700, Jason Ekstrand wrote: >On Sep 1, 2016 1:31 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@gmail.com> wrote: >> >> On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: >> > While it can be useful, the field has substantial

Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-01 Thread Jason Ekstrand
On Sep 1, 2016 1:31 AM, "Pohjolainen, Topi" wrote: > > On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: > > While it can be useful, the field has substantial limtations. In > > particular, the bittom 2 or 3 bits is missing so your offset always has to >

Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-01 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: > While it can be useful, the field has substantial limtations. In > particular, the bittom 2 or 3 bits is missing so your offset always has to bottom > be a multiple of 4 or 8. While surface alignments usually

[Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-08-31 Thread Jason Ekstrand
While it can be useful, the field has substantial limtations. In particular, the bittom 2 or 3 bits is missing so your offset always has to be a multiple of 4 or 8. While surface alignments usually work out to make this ok, when you start trying to fake compressed surfaces as uncompressed (which