Re: [Mesa-dev] [PATCH 15/28] nir: support for denorm flush-to-zero in nir_lower_double_ops

2018-12-10 Thread Samuel Iglesias Gonsálvez
On 05/12/2018 19:35, Connor Abbott wrote: > All the current lowerings produce their result using a floating-point > multiply or add, so denorms should already be flushed (e.g. > nir_op_frcp), or they never produce a denorm (e.g. nir_op_ftrunc), so > I don't think this is necessary. This fix is

Re: [Mesa-dev] [PATCH 15/28] nir: support for denorm flush-to-zero in nir_lower_double_ops

2018-12-10 Thread Samuel Iglesias Gonsálvez
On 05/12/2018 19:35, Connor Abbott wrote: > All the current lowerings produce their result using a floating-point > multiply or add, so denorms should already be flushed (e.g. > nir_op_frcp), or they never produce a denorm (e.g. nir_op_ftrunc), so > I don't think this is necessary. Right,

Re: [Mesa-dev] [PATCH 15/28] nir: support for denorm flush-to-zero in nir_lower_double_ops

2018-12-05 Thread Connor Abbott
All the current lowerings produce their result using a floating-point multiply or add, so denorms should already be flushed (e.g. nir_op_frcp), or they never produce a denorm (e.g. nir_op_ftrunc), so I don't think this is necessary. On Wed, Dec 5, 2018 at 4:56 PM Samuel Iglesias Gonsálvez wrote:

[Mesa-dev] [PATCH 15/28] nir: support for denorm flush-to-zero in nir_lower_double_ops

2018-12-05 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_double_ops.c | 12 1 file changed, 12 insertions(+) diff --git a/src/compiler/nir/nir_lower_double_ops.c b/src/compiler/nir/nir_lower_double_ops.c index b3543bc6963..97b825d2fdb 100644 ---