Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-11 Thread Alex Deucher
On Sat, Aug 10, 2013 at 11:09 AM, Christian König wrote: > Am 10.08.2013 15:53, schrieb Marek Olšák: > >> The RCU approach sounds good, but you can never know if 16 is enough. >> We should release the buffer once it is full and allocate a new one. >> The cache bufmgr in the winsys will assure ther

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-11 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 05:36:07PM +0200, Marek Olšák wrote: > On Sat, Aug 10, 2013 at 5:09 PM, Christian König > wrote: > > Am 10.08.2013 15:53, schrieb Marek Olšák: > > > >> The RCU approach sounds good, but you can never know if 16 is enough. > >> We should release the buffer once it is full an

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-10 Thread Marek Olšák
On Sat, Aug 10, 2013 at 5:09 PM, Christian König wrote: > Am 10.08.2013 15:53, schrieb Marek Olšák: > >> The RCU approach sounds good, but you can never know if 16 is enough. >> We should release the buffer once it is full and allocate a new one. >> The cache bufmgr in the winsys will assure there

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-10 Thread Christian König
Am 10.08.2013 15:53, schrieb Marek Olšák: The RCU approach sounds good, but you can never know if 16 is enough. We should release the buffer once it is full and allocate a new one. The cache bufmgr in the winsys will assure there won't be any buffer allocation overhead - it would work kinda a lik

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-10 Thread Marek Olšák
The RCU approach sounds good, but you can never know if 16 is enough. We should release the buffer once it is full and allocate a new one. The cache bufmgr in the winsys will assure there won't be any buffer allocation overhead - it would work kinda a like a ring of buffers. Marek On Sat, Aug 10,

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-10 Thread Christian König
Am 09.08.2013 20:06, schrieb Marek Olšák: [SNIP] What if I kept the current emission code, and only allocated a new buffer at the end of the emit function, copied all descriptors to it using CP_DMA or COPY_DATA, and pointed SPI_SHADER_USER_DATA to it. The buffer where the descriptors are updated

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Marek Olšák
On Fri, Aug 9, 2013 at 3:48 PM, Christian König wrote: > Am 09.08.2013 15:29, schrieb Marek Olšák: >> >> On Fri, Aug 9, 2013 at 10:34 AM, Christian König >> wrote: >>> >>> Am 08.08.2013 21:38, schrieb Alex Deucher: >>> On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: > > On Thu, A

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Christian König
Am 09.08.2013 15:29, schrieb Marek Olšák: On Fri, Aug 9, 2013 at 10:34 AM, Christian König wrote: Am 08.08.2013 21:38, schrieb Alex Deucher: On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: Am 08.08.2013 16:33, schrieb Marek Olšák:

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Marek Olšák
On Fri, Aug 9, 2013 at 10:34 AM, Christian König wrote: > Am 08.08.2013 21:38, schrieb Alex Deucher: > >> On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: >>> >>> On Thu, Aug 8, 2013 at 6:57 PM, Christian König >>> wrote: Am 08.08.2013 16:33, schrieb Marek Olšák: > > On Thu,

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Christian König
Am 08.08.2013 21:38, schrieb Alex Deucher: On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: Am 08.08.2013 16:33, schrieb Marek Olšák: On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: Am 08.08.2013 14:38, schrieb Marek Olšák:

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Alex Deucher
On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: > On Thu, Aug 8, 2013 at 6:57 PM, Christian König > wrote: >> Am 08.08.2013 16:33, schrieb Marek Olšák: >>> >>> On Thu, Aug 8, 2013 at 3:09 PM, Christian König >>> wrote: Am 08.08.2013 14:38, schrieb Marek Olšák: > .On Thu, A

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: > Am 08.08.2013 16:33, schrieb Marek Olšák: >> >> On Thu, Aug 8, 2013 at 3:09 PM, Christian König >> wrote: >>> >>> Am 08.08.2013 14:38, schrieb Marek Olšák: >>> .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: > > A

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 16:33, schrieb Marek Olšák: On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: Am 08.08.2013 14:38, schrieb Marek Olšák: .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every text

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: > Am 08.08.2013 14:38, schrieb Marek Olšák: > >> .On Thu, Aug 8, 2013 at 9:47 AM, Christian König >> wrote: >>> >>> Am 08.08.2013 02:20, schrieb Marek Olšák: >>> FMASK is bound as a separate texture. For every texture, there can be

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 14:38, schrieb Marek Olšák: .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every texture, there can be an FMASK. Therefore a separate array of resource slots has to be added. This adds

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
.On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: > Am 08.08.2013 02:20, schrieb Marek Olšák: > >> FMASK is bound as a separate texture. For every texture, there can be >> an FMASK. Therefore a separate array of resource slots has to be added. >> >> This adds a new mechanism for emitting res

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every texture, there can be an FMASK. Therefore a separate array of resource slots has to be added. This adds a new mechanism for emitting resource descriptors, its features are: - resource descriptors are stored

[Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-07 Thread Marek Olšák
FMASK is bound as a separate texture. For every texture, there can be an FMASK. Therefore a separate array of resource slots has to be added. This adds a new mechanism for emitting resource descriptors, its features are: - resource descriptors are stored in an ordinary buffer (not in a CS) - descr