Re: [Mesa-dev] [PATCH 19/53] st/nine: Clamp color inputs for ps = 2.0 at ps level instead of vs

2015-01-11 Thread Marek Olšák
BTW, colors should indeed be clamped for SM 2.0 in the VS. The reason is that old ps2.0 hardware used the R8G8B8A8_UNORM format for color varyings, meaning that all colors were always clamped when they left the vertex shader and this behavior couldn't be disabled. r300-r400 behave this way, so

Re: [Mesa-dev] [PATCH 19/53] st/nine: Clamp color inputs for ps = 2.0 at ps level instead of vs

2015-01-11 Thread Axel Davy
On 07/01/2015 17:36, Axel Davy wrote : Nine code was clamping color outputs for vs 3, but msdn docs says it is done in the ps. Wine seems to clamp them at the vs level. It makes more sense to clamp at vs level for performance, but according to doc, ps 2.x shouldn't see clamping. We have

[Mesa-dev] [PATCH 19/53] st/nine: Clamp color inputs for ps = 2.0 at ps level instead of vs

2015-01-07 Thread Axel Davy
Nine code was clamping color outputs for vs 3, but msdn docs says it is done in the ps. Wine seems to clamp them at the vs level. It makes more sense to clamp at vs level for performance, but according to doc, ps 2.x shouldn't see clamping. Reviewed-by: David Heidelberg da...@ixit.cz