Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-24 Thread Ian Romanick
On 05/23/2016 07:45 AM, Marek Olšák wrote: > I think it would be better to put stuff like this only into the > renderer string of drivers which use LLVM. The majority of drivers > don't care about the LLVM version. Yes. In fact, I *really* don't want the LLVM version to show up in the glxinfo

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-24 Thread Giuseppe Bilotta
On Tue, May 24, 2016 at 12:46 AM, Marek Olšák wrote: > On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta > wrote: >> On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: >>> I think it would be better to put stuff like this only

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-24 Thread Giuseppe Bilotta
On Tue, May 24, 2016 at 1:03 AM, Vedran Miletic wrote: > > What is the state of MESA_LLVM_VERSION_STRING if you build Mesa on a system > without LLVM? I set it to the empty string. -- Giuseppe "Oblomov" Bilotta ___ mesa-dev

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/23/2016 09:21 AM, Giuseppe Bilotta wrote: Code generation (kernel compilation) may sometimes hit LLVM-specific bugs. Adding the used LLVM version to the version string may make bug triaging easier. (This was inspired by a similar patch recently proposed for pocl.) Signed-off-by: Giuseppe

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/24/2016 12:46 AM, Marek Olšák wrote: On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: I think it would be better to put stuff like this only into the renderer string of drivers

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Marek Olšák
On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: > On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: >> I think it would be better to put stuff like this only into the >> renderer string of drivers which use LLVM. The majority of drivers

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Giuseppe Bilotta
On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: > I think it would be better to put stuff like this only into the > renderer string of drivers which use LLVM. The majority of drivers > don't care about the LLVM version. Hm, that might be a good point. Is there a way to

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Serge Martin
On Monday 23 May 2016 09:21:51 Giuseppe Bilotta wrote: > Code generation (kernel compilation) may sometimes hit LLVM-specific > bugs. Adding the used LLVM version to the version string may make bug > triaging easier. (This was inspired by a similar patch recently > proposed for pocl.) > >

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Marek Olšák
I think it would be better to put stuff like this only into the renderer string of drivers which use LLVM. The majority of drivers don't care about the LLVM version. Marek On Mon, May 23, 2016 at 9:21 AM, Giuseppe Bilotta wrote: > Code generation (kernel compilation)

[Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Giuseppe Bilotta
Code generation (kernel compilation) may sometimes hit LLVM-specific bugs. Adding the used LLVM version to the version string may make bug triaging easier. (This was inspired by a similar patch recently proposed for pocl.) Signed-off-by: Giuseppe Bilotta ---