Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-07 Thread Ian Romanick
On 04/07/2016 06:17 AM, Rogovin, Kevin wrote: > Hello, > >> typo -> ...query (same goes for patch 1/2) > > I hate typos. Thanks for pointing it out. > >> Please correct me if I'm wrong, but I think we cannot unalias functions once >> they're in. >> It will break the backwards compatibility

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-07 Thread Rogovin, Kevin
Hello, > typo -> ...query (same goes for patch 1/2) I hate typos. Thanks for pointing it out. > Please correct me if I'm wrong, but I think we cannot unalias functions once > they're in. > It will break the backwards compatibility we're trying to manage with glapi. > If we want to > retain

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Emil Velikov
Hi Kevin, On 5 April 2016 at 12:27, wrote: > From: Kevin Rogovin > > The extension, GL_ARB_occlusion_queries typo -> ...query (same goes for patch 1/2) > mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Matt Turner
On Tue, Apr 5, 2016 at 4:27 AM, wrote: > From: Kevin Rogovin Subject is missing a required prefix. > The extension, GL_ARB_occlusion_queries mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called while a query is

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-06 Thread Iago Toral
On Tue, 2016-04-05 at 14:27 +0300, kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > The extension, GL_ARB_occlusion_queries mandates that an > INVALID_OPERATION should be thrown if DeleteQueriesARB is > called while a query is active. In contrast, the GL spec >

[Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

2016-04-05 Thread kevin . rogovin
From: Kevin Rogovin The extension, GL_ARB_occlusion_queries mandates that an INVALID_OPERATION should be thrown if DeleteQueriesARB is called while a query is active. In contrast, the GL spec has no such requirement for DeleteQueries. This patch unaliases the two