On 9/17/18 1:43 AM, Lionel Landwerlin wrote:
On 16/09/2018 21:57, Bas Nieuwenhuizen wrote:
On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin
wrote:
This new extension adds an implicitly allocated block of uniforms into
the descriptors sets through a new descriptor type.
We implement this
On 16/09/2018 21:57, Bas Nieuwenhuizen wrote:
On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin
wrote:
This new extension adds an implicitly allocated block of uniforms into
the descriptors sets through a new descriptor type.
We implement this by having a single BO in the descriptor set pool
On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin
wrote:
>
> This new extension adds an implicitly allocated block of uniforms into
> the descriptors sets through a new descriptor type.
>
> We implement this by having a single BO in the descriptor set pool
> from which we source uniforms.
>
>
Hey Tapani,
Descriptors were kind of tricky to get my head around so thanks a lot
for looking into this.
Regarding this max values, there isn't really a limit with our hardware.
I just picked the minimum required by the spec.
I think the assert are somewhat unnecessary but I don't really
I can't say I know enough of all these parts but I went through the API
functions and tried to check that you have proper checks in place. Will
try to still review :)
I did not see any check against MAX_INLINE_UNIFORM_BLOCK_DESCRIPTORS
when creating pipeline layout. I'm not sure if such is
This new extension adds an implicitly allocated block of uniforms into
the descriptors sets through a new descriptor type.
We implement this by having a single BO in the descriptor set pool
from which we source uniforms.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_cmd_buffer.c
