Re: [Mesa-dev] [PATCH 2/2] gallivm, draw, llvmpipe: mass rename of unit-texture_unit/sampler_unit

2013-01-28 Thread Jose Fonseca
Thanks Roland. I'd do s/texture_unit/resource_unit/g, as buffers bindings are/will be accepted. Either way: Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - From: Roland Scheidegger srol...@vmware.com Make it obvious what unit this is (no change in

Re: [Mesa-dev] [PATCH 2/2] gallivm, draw, llvmpipe: mass rename of unit-texture_unit/sampler_unit

2013-01-26 Thread Brian Paul
On 01/25/2013 05:36 PM, srol...@vmware.com wrote: From: Roland Scheideggersrol...@vmware.com Make it obvious what unit this is (no change in functionality). draw still uses unit in places where it changes the shader by adding texture sampling itself - it seems like this can't work with shaders

[Mesa-dev] [PATCH 2/2] gallivm, draw, llvmpipe: mass rename of unit-texture_unit/sampler_unit

2013-01-25 Thread sroland
From: Roland Scheidegger srol...@vmware.com Make it obvious what unit this is (no change in functionality). draw still uses unit in places where it changes the shader by adding texture sampling itself - it seems like this can't work with shaders using dx10-style sample opcodes (can't mix gl-style