Re: [Mesa-dev] [PATCH 2/2] glsl: Don't copy propagate elements from SSBO or shared variables either

2018-06-13 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jun 12, 2018 at 03:48:14PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Since SSBOs can be written, copy propagating a read can cause the > value to magically change. SSBO reads are also very expensive, so > doing it twice will be slo

[Mesa-dev] [PATCH 2/2] glsl: Don't copy propagate elements from SSBO or shared variables either

2018-06-12 Thread Ian Romanick
From: Ian Romanick Since SSBOs can be written, copy propagating a read can cause the value to magically change. SSBO reads are also very expensive, so doing it twice will be slower. The same shader was helped by this patch and the previous. Haswell, Broadwell, and Skylake had similar results.