Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Kenneth Graunke
On Wednesday, August 29, 2018 1:12:28 PM PDT Ian Romanick wrote: > From: Ian Romanick > > Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid > range of the offset is [0, 0FFFh]. > > Signed-off-by: Ian Romanick > Cc: mesa-sta...@lists.freedesktop.org > Cc: Kenneth Graunke

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 4:32 PM Ian Romanick wrote: > On 08/29/2018 02:22 PM, Jason Ekstrand wrote: > > Have you seen this cause an actual problem? There's no way we can > > actually end up with an input array that big... I guess this is for the > > crazy OOB case? > > The array can't be that b

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Ian Romanick
On 08/29/2018 02:22 PM, Jason Ekstrand wrote: > Have you seen this cause an actual problem?  There's no way we can > actually end up with an input array that big...  I guess this is for the > crazy OOB case? The array can't be that big due to other compiler limits. This is just to prevent a garba

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Jason Ekstrand
Have you seen this cause an actual problem? There's no way we can actually end up with an input array that big... I guess this is for the crazy OOB case? On Wed, Aug 29, 2018 at 3:12 PM Ian Romanick wrote: > From: Ian Romanick > > Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says t

[Mesa-dev] [PATCH 2/2] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

2018-08-29 Thread Ian Romanick
From: Ian Romanick Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid range of the offset is [0, 0FFFh]. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org Cc: Kenneth Graunke --- src/intel/compiler/brw_vec4_tes.cpp | 12 +++- 1 file changed, 11