Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-03 Thread Kenneth Graunke
On Wednesday, July 02, 2014 10:09:49 AM Iago Toral wrote: > On Wed, 2014-07-02 at 08:49 +0200, Iago Toral wrote: > > Hello Kenneth, Steven: > > > > On Tue, 2014-07-01 at 17:25 -0700, Kenneth Graunke wrote: > > > Previously, we only emitted 3DSTATE_SO_BUFFER and 3DSTATE_SO_DECL_LIST > > > when tran

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Steven Newbury
On Wed, 2014-07-02 at 15:40 +0100, Steven Newbury wrote: > On Wed, 2014-07-02 at 10:59 +0200, Iago Toral wrote: > > Oh, I just noticed there was some problem with the first reply I > > sent > > and Chris and Steven got out of the CC in my reply, so adding them > > back > > now. > > Steven: th

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Steven Newbury
On Wed, 2014-07-02 at 10:59 +0200, Iago Toral wrote: > Oh, I just noticed there was some problem with the first reply I sent > and Chris and Steven got out of the CC in my reply, so adding them > back > now. > > Steven: the summary is that on IvyBridge Kenneth's second patch > produces > a GPU

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
Oh, I just noticed there was some problem with the first reply I sent and Chris and Steven got out of the CC in my reply, so adding them back now. Steven: the summary is that on IvyBridge Kenneth's second patch produces a GPU hang in some cases so if you are going to test it try this version bette

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
On Wed, 2014-07-02 at 08:49 +0200, Iago Toral wrote: > Hello Kenneth, Steven: > > On Tue, 2014-07-01 at 17:25 -0700, Kenneth Graunke wrote: > > Previously, we only emitted 3DSTATE_SO_BUFFER and 3DSTATE_SO_DECL_LIST > > when transform feedback was active. When it was inactive, we disabled > > the

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-01 Thread Kenneth Graunke
On Tuesday, July 01, 2014 08:26:48 PM Jordan Justen wrote: > Should this be i965/gen7? (Seems to be a no-op for gen8.) > > Series Reviewed-by: Jordan Justen > > Speaking of xfb and gen8, I rebased a ~week old branch today, and saw > two regressions: > spec/EXT_transform_feedback/primgen-query tr

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-01 Thread Jordan Justen
Should this be i965/gen7? (Seems to be a no-op for gen8.) Series Reviewed-by: Jordan Justen Speaking of xfb and gen8, I rebased a ~week old branch today, and saw two regressions: spec/EXT_transform_feedback/primgen-query transform-feedback-disabled: pass fail spec/ARB_transform_feedback2/countin

[Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-01 Thread Kenneth Graunke
Previously, we only emitted 3DSTATE_SO_BUFFER and 3DSTATE_SO_DECL_LIST when transform feedback was active. When it was inactive, we disabled the SOL stage in 3DSTATE_SOL so the other state would be ignored. In commit 3178d2474ae5bdd1102fb3d76a60d1d63c961ff5, Iago enabled the SOL stage universally