Hi Ken,
Thank you so much for reviewing and helping me out with this! I'll make the
changes you suggested
to both patches and resubmit.
Thanks,
Pam
On Tue, Sep 26, 2017 at 3:32 AM, Kenneth Graunke
wrote:
> On Tuesday, August 29, 2017 9:24:01 AM PDT Plamena Manolova
On Tuesday, August 29, 2017 9:24:01 AM PDT Plamena Manolova wrote:
> We can implement ARB_indirect_parameters for i965 by
> taking advantage of the conditional rendering mechanism.
> This works by issuing maxdrawcount draw calls and using
> conditional rendering to predicate each of them with
>
Thank you for taking a look Jason!
Sorry my bad, I'll make sure to add some comments to v2 at least. Hopefully
it'll make editing this portion of
the i965 drawing logic a bit easier.
On Fri, Sep 8, 2017 at 4:48 AM, Jason Ekstrand wrote:
> Hey Pam!
>
> A quick skim through
Hey Pam!
A quick skim through this looks fairly good. I'll be honest, I expected to
have some quick comments on the v1 but I'm not seeing anything
immediately. That said, I've got to think about it fairly hard to convince
myself that it's actually correct. The i965 drawing logic isn't really
On Thu, Aug 31, 2017 at 1:45 PM, Bas Nieuwenhuizen
wrote:
>
>
> On Wed, Aug 30, 2017, at 14:59, Ilia Mirkin wrote:
>> On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
>> wrote:
>> > So as a random drive-by review, I think the risk in this
On Wed, Aug 30, 2017, at 14:59, Ilia Mirkin wrote:
> On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
> wrote:
> > So as a random drive-by review, I think the risk in this implementation
> > is that apps just set maxdrawcount to some high value . If I'm reading
> >
On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
wrote:
> So as a random drive-by review, I think the risk in this implementation
> is that apps just set maxdrawcount to some high value . If I'm reading
> the spec correctly there is no real bound on the value except
So as a random drive-by review, I think the risk in this implementation
is that apps just set maxdrawcount to some high value . If I'm reading
the spec correctly there is no real bound on the value except for the
max-representable value for the integer. Also AFAIK the AMD and NVidia
We can implement ARB_indirect_parameters for i965 by
taking advantage of the conditional rendering mechanism.
This works by issuing maxdrawcount draw calls and using
conditional rendering to predicate each of them with
"drawcount > gl_DrawID"
Signed-off-by: Plamena Manolova