Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

2018-03-12 Thread Jordan Justen
On 2018-03-12 14:51:56, Timothy Arceri wrote: > This only seems to be needed by i965. Alternative can't you just remove the: > > if (prog->sh.data->LinkStatus != LINKING_SKIPPED) >goto fail; > > from brw_disk_cache_upload_program() and let the cache search do its job? > > I believe

Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

2018-03-12 Thread Timothy Arceri
This only seems to be needed by i965. Alternative can't you just remove the: if (prog->sh.data->LinkStatus != LINKING_SKIPPED) goto fail; from brw_disk_cache_upload_program() and let the cache search do its job? I believe its possible to end up linking the GLSL IR i.e.

[Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

2018-03-11 Thread Jordan Justen
This change allows the disk shader cache to work with programs loaded with ProgramBinary. Drivers check for LINKING_SKIPPED, and if set, then they try to use the shader cache. Since the program loaded by ProgramBinary is similar to loading the shader from the disk cache, this is probably more