Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Marek Olšák
On Sat, Nov 19, 2016 at 1:13 AM, Tom Stellard wrote: > On Sat, Nov 19, 2016 at 01:09:00AM +0100, Marek Olšák wrote: >> On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: >> > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: >> >> Have you looked at the shader-db impact? >> >> >>

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Tom Stellard
On Sat, Nov 19, 2016 at 01:09:00AM +0100, Marek Olšák wrote: > On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: > > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: > >> Have you looked at the shader-db impact? > >> > > > > shader-db is mostly unchanged. There are a few decreas

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-18 Thread Marek Olšák
On Wed, Nov 16, 2016 at 4:38 PM, Tom Stellard wrote: > On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: >> Have you looked at the shader-db impact? >> > > shader-db is mostly unchanged. There are a few decreases in SGPR usage and > code size, and a 4 byte increase in code size for

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-16 Thread Nicolai Hähnle
On 16.11.2016 16:38, Tom Stellard wrote: On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: Have you looked at the shader-db impact? shader-db is mostly unchanged. There are a few decreases in SGPR usage and code size, and a 4 byte increase in code size for one shader. Okay, i

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-16 Thread Tom Stellard
On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: > Have you looked at the shader-db impact? > shader-db is mostly unchanged. There are a few decreases in SGPR usage and code size, and a 4 byte increase in code size for one shader. > I do think we should eventually do this, but ll

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-16 Thread Nicolai Hähnle
Have you looked at the shader-db impact? I do think we should eventually do this, but llvm.SI.vs.load.input is ReadNone while llvm.amdgcn.buffer.load.* is only ReadOnly, so as long as we can't teach LLVM properly about no-aliasing and speculability, there may be performance regressions. Chee

[Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

2016-11-15 Thread Tom Stellard
--- src/gallium/drivers/radeonsi/si_shader.c | 69 +++- 1 file changed, 50 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 306e12f..ee4fe2f 100644 --- a/src/gallium/drivers/radeonsi/