Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-25 Thread Bas Nieuwenhuizen
On Fri, May 25, 2018 at 12:45 PM, Timothy Arceri wrote: > > > On 25/05/18 20:40, Timothy Arceri wrote: >> >> On 25/05/18 19:57, Samuel Pitoiset wrote: >>> >>> On 05/25/2018 04:28 AM, Timothy Arceri wrote: On 25/05/18 11:24, Bas Nieuwenhuizen wrote: > > On

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-25 Thread Timothy Arceri
On 25/05/18 20:40, Timothy Arceri wrote: On 25/05/18 19:57, Samuel Pitoiset wrote: On 05/25/2018 04:28 AM, Timothy Arceri wrote: On 25/05/18 11:24, Bas Nieuwenhuizen wrote: On Fri, May 25, 2018 at 2:25 AM, Timothy Arceri wrote:  From what I recall with my testing

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-25 Thread Timothy Arceri
On 25/05/18 19:57, Samuel Pitoiset wrote: On 05/25/2018 04:28 AM, Timothy Arceri wrote: On 25/05/18 11:24, Bas Nieuwenhuizen wrote: On Fri, May 25, 2018 at 2:25 AM, Timothy Arceri wrote:  From what I recall with my testing on radeonsi this wasn't really the ideal

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-25 Thread Samuel Pitoiset
On 05/25/2018 04:28 AM, Timothy Arceri wrote: On 25/05/18 11:24, Bas Nieuwenhuizen wrote: On Fri, May 25, 2018 at 2:25 AM, Timothy Arceri wrote:  From what I recall with my testing on radeonsi this wasn't really the ideal thing to do. Especially when varyings arrays

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-24 Thread Timothy Arceri
On 25/05/18 11:24, Bas Nieuwenhuizen wrote: On Fri, May 25, 2018 at 2:25 AM, Timothy Arceri wrote: From what I recall with my testing on radeonsi this wasn't really the ideal thing to do. Especially when varyings arrays are accessed via and indirect index, register use

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-24 Thread Bas Nieuwenhuizen
On Fri, May 25, 2018 at 2:25 AM, Timothy Arceri wrote: > > From what I recall with my testing on radeonsi this wasn't really the ideal > thing to do. Especially when varyings arrays are accessed via and indirect > index, register use very quickly gets out of control. in

Re: [Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-24 Thread Timothy Arceri
From what I recall with my testing on radeonsi this wasn't really the ideal thing to do. Especially when varyings arrays are accessed via and indirect index, register use very quickly gets out of control. On 23/05/18 22:31, Samuel Pitoiset wrote: Do not lower FS inputs because this moves

[Mesa-dev] [PATCH 2/2] radv: call nir_lower_io_to_temporaries for VS, GS, TES and FS

2018-05-23 Thread Samuel Pitoiset
Do not lower FS inputs because this moves all load_var instructions at beginning of shaders and because interp_var_at_sample (and friends) seem broken. That might be eventually enabled later on if we really want to preload all FS inputs at beginning. Polaris10: Totals from affected shaders: