Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

On 11 January 2018 at 20:15, Alex Smith wrote: > Hi Dave, > > This seems to cause some breakage when both push constants and dynamic > descriptors are used. > > I've commented 2 fixes inline below needed to avoid a crash, but with those > F1 2017 will still hang

Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

On 01/11/2018 04:03 AM, Dave Airlie wrote: From: Dave Airlie Instead of putting the push constants into the upload buffer, if we have space in the sgprs we can upload the per-stage constants into the shaders directly. This saves a few reads from memory in the meta

Re: [Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

Hi Dave, This seems to cause some breakage when both push constants and dynamic descriptors are used. I've commented 2 fixes inline below needed to avoid a crash, but with those F1 2017 will still hang pretty quick before the main menu, not sure why so far. Mad Max is OK but that doesn't use

[Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

From: Dave Airlie Instead of putting the push constants into the upload buffer, if we have space in the sgprs we can upload the per-stage constants into the shaders directly. This saves a few reads from memory in the meta shaders, we should also be able to inline other