Re: [Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-29 Thread Samuel Iglesias Gonsálvez
On Thu, 2019-03-28 at 16:21 +0100, Samuel Pitoiset wrote: > On 3/25/19 8:16 AM, Samuel Iglesias Gonsálvez wrote: > > On Fri, 2019-03-22 at 17:21 +0100, Samuel Pitoiset wrote: > > > Does this fix anything known? > > > > > I am writing CTS tests for VK_EXT_host_query_reset extension and I > > found

Re: [Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-28 Thread Samuel Pitoiset
On 3/25/19 8:16 AM, Samuel Iglesias Gonsálvez wrote: On Fri, 2019-03-22 at 17:21 +0100, Samuel Pitoiset wrote: Does this fix anything known? I am writing CTS tests for VK_EXT_host_query_reset extension and I found this bug while testing them on RADV. Does that rule also apply for

Re: [Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-25 Thread Samuel Iglesias Gonsálvez
On Fri, 2019-03-22 at 17:21 +0100, Samuel Pitoiset wrote: > Does this fix anything known? > I am writing CTS tests for VK_EXT_host_query_reset extension and I found this bug while testing them on RADV. > Does that rule also apply for CmdCopyQueryPoolResults()? If so, we > might > need to fix

Re: [Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-22 Thread Samuel Pitoiset
Does this fix anything known? Does that rule also apply for CmdCopyQueryPoolResults()? If so, we might need to fix it (I haven't looked yet). With the comment on patch 1, series is: Reviewed-by: Samuel Pitoiset On 3/22/19 1:03 PM, Samuel Iglesias Gonsálvez wrote: If

[Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-22 Thread Samuel Iglesias Gonsálvez
If VK_QUERY_RESULT_WITH_AVAILABILY_BIT is set and VK_QUERY_RESULT_WAIT_BIT and VK_QUERY_RESULT_PARTIAL_BIT are both not set, we need return to VK_NOT_READY only and set the availability status field for each query. From Vulkan spec: "If VK_QUERY_RESULT_WAIT_BIT and VK_QUERY_RESULT_PARTIAL_BIT