Re: [Mesa-dev] [PATCH 2/3] intel/blorp: Make KSP a blorp_address instead of an offset.

2018-12-07 Thread Jason Ekstrand
I somewhat recant my statements below. Even in a driver that puts the full address in the offset field, having the BO pointer may still be useful for the purpose of adding it to a residency list somewhere. On Fri, Dec 7, 2018 at 4:13 PM Jason Ekstrand wrote: > I kind-of wonder if we want to

Re: [Mesa-dev] [PATCH 2/3] intel/blorp: Make KSP a blorp_address instead of an offset.

2018-12-07 Thread Jason Ekstrand
I kind-of wonder if we want to allow for relocations and not surface state base address in which case you'd want to do something "real" with offset. Making this an address and then ignoring the buffer part entirely seems like it promises a bit too much. Then again, I don't think it's really

[Mesa-dev] [PATCH 2/3] intel/blorp: Make KSP a blorp_address instead of an offset.

2018-11-29 Thread Kenneth Graunke
In i965, shader programs live in a single buffer, and every batch emits a STATE_BASE_ADDRESS packet pointing to that buffer. This takes care of pinning the buffer for the batch; from then on, we can use an offset. In the upcoming Iris driver, shader programs can live in multiple buffers, and