Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-08 Thread Marek Olšák
Alright. For the patch: Reviewed-by: Marek Olšák Marek On Wed, Jul 9, 2014 at 2:48 AM, Ilia Mirkin wrote: > So... I don't think we're going to figure this out here. At least I > have nothing enlightening to say. FWIW this is doing the same thing as > what i965 does wrt the persample_shading co

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-08 Thread Ilia Mirkin
So... I don't think we're going to figure this out here. At least I have nothing enlightening to say. FWIW this is doing the same thing as what i965 does wrt the persample_shading computation. It should be pretty easy to change should we decide on a different interpretation of the spec. The only q

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-05 Thread Ilia Mirkin
On Sat, Jul 5, 2014 at 6:22 PM, Marek Olšák wrote: > There is this vague statement in the sample shading spec: > > When the sample shading fraction is 1.0, a separate set of colors and > other associated data are evaluated for each sample, each set of values > are evaluated at the samp

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-05 Thread Marek Olšák
What you say makes sense. I'm just asking what that sentence in the spec means if it isn't about interpolation. :) Marek On Sun, Jul 6, 2014 at 12:40 AM, Ilia Mirkin wrote: > On Sat, Jul 5, 2014 at 6:22 PM, Marek Olšák wrote: >> There is this vague statement in the sample shading spec: >> >>

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-05 Thread Ilia Mirkin
On Sat, Jul 5, 2014 at 6:22 PM, Marek Olšák wrote: > There is this vague statement in the sample shading spec: > > When the sample shading fraction is 1.0, a separate set of colors and > other associated data are evaluated for each sample, each set of values > are evaluated at the samp

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-05 Thread Marek Olšák
There is this vague statement in the sample shading spec: When the sample shading fraction is 1.0, a separate set of colors and other associated data are evaluated for each sample, each set of values are evaluated at the sample location. I thought it was about interpolation, meaning t

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-05 Thread Roland Scheidegger
Looks good to me. It is unfortunate I guess that shaders may need recompilation just because the inputs are interpolated differently but I don't see a easy way out there. Roland Am 05.07.2014 06:07, schrieb Ilia Mirkin: > This enables a gallium driver not to care about the semantics of > ARB_samp

[Mesa-dev] [PATCH 2/3] mesa/st: add per sample shading state to fp key and set interpolation

2014-07-04 Thread Ilia Mirkin
This enables a gallium driver not to care about the semantics of ARB_sample_shading vs ARB_gpu_shader5 sample attributes. When ARB_sample_shading-style sample shading is enabled, all of the fp inputs are marked for interpolation at the sample location. Signed-off-by: Ilia Mirkin --- I _think_ I