Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5 (v3)

2019-03-21 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Thanks for bearing with my nits. On Thu, Mar 21, 2019 at 2:43 PM Rob Clark wrote: > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > sufficiently high ESSL feature level, even if the GLSL feature level > isn't high enough. > > This allows drivers

[Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5 (v3)

2019-03-21 Thread Rob Clark
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a sufficiently high ESSL feature level, even if the GLSL feature level isn't high enough. This allows drivers to support EXT_gpu_shader5 in GLES contexts before they support all the additional features of ARB_gpu_shader5 in GL

Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5 (v2)

2019-03-21 Thread Rob Clark
On Thu, Mar 21, 2019 at 2:19 PM Ilia Mirkin wrote: > > On Thu, Mar 21, 2019 at 1:45 PM Rob Clark wrote: > > > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > > sufficiently high ESSL feature level, even if the GLSL feature level > > isn't high enough. > > > > This allows

Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5 (v2)

2019-03-21 Thread Ilia Mirkin
On Thu, Mar 21, 2019 at 1:45 PM Rob Clark wrote: > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > sufficiently high ESSL feature level, even if the GLSL feature level > isn't high enough. > > This allows drivers to support EXT_gpu_shader5 in GLES contexts before > they

[Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5 (v2)

2019-03-21 Thread Rob Clark
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a sufficiently high ESSL feature level, even if the GLSL feature level isn't high enough. This allows drivers to support EXT_gpu_shader5 in GLES contexts before they support all the additional features of ARB_gpu_shader5 in GL

Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5

2019-03-21 Thread Ilia Mirkin
On Thu, Mar 21, 2019 at 10:18 AM Rob Clark wrote: > > On Thu, Mar 21, 2019 at 10:09 AM Ilia Mirkin wrote: > > > > On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote: > > > > > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > > > sufficiently high ESSL feature level, even if

Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5

2019-03-21 Thread Rob Clark
On Thu, Mar 21, 2019 at 10:09 AM Ilia Mirkin wrote: > > On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote: > > > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > > sufficiently high ESSL feature level, even if the GLSL feature level > > isn't high enough. > > > > This allows

Re: [Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5

2019-03-21 Thread Ilia Mirkin
On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote: > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a > sufficiently high ESSL feature level, even if the GLSL feature level > isn't high enough. > > This allows drivers to support EXT_gpu_shader5 in GLES contexts before > they

[Mesa-dev] [PATCH 2/3] mesa/st: use ESSL cap top enable gpu_shader5

2019-03-21 Thread Rob Clark
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a sufficiently high ESSL feature level, even if the GLSL feature level isn't high enough. This allows drivers to support EXT_gpu_shader5 in GLES contexts before they support all the additional features of ARB_gpu_shader5 in GL