Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

2017-06-26 Thread Wladimir J. van der Laan
On Sat, Jun 24, 2017 at 10:41:58AM +0200, Christian Gmeiner wrote: > Hi > > 2017-06-22 14:39 GMT+02:00 Wladimir J. van der Laan : > > On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > >> Passes all ext_texture_swizzle piglits. > > > > You seem to have dropped

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

2017-06-24 Thread Christian Gmeiner
Hi 2017-06-22 14:39 GMT+02:00 Wladimir J. van der Laan : > On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: >> Passes all ext_texture_swizzle piglits. > > You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture > formats have implicit

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

2017-06-22 Thread Wladimir J. van der Laan
On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > Passes all ext_texture_swizzle piglits. You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture formats have implicit non-identity swizzle. I do think that is necessary as those formats don't work on

[Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

2017-06-21 Thread Christian Gmeiner
Passes all ext_texture_swizzle piglits. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 91 ++- src/gallium/drivers/etnaviv/etnaviv_format.h | 4 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-