Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 16:54, Iago Toral wrote: On Fri, 2017-10-20 at 13:18 +1100, Timothy Arceri wrote: On 20/10/17 03:31, Iago Toral Quiroga wrote: The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to check aliasing for each

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Fri, 2017-10-20 at 13:18 +1100, Timothy Arceri wrote: > > On 20/10/17 03:31, Iago Toral Quiroga wrote: > > The existing code was checking the whole interface variable rather > > than its members, which is not what we want: we want to check > > aliasing for each member in the interface

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 13:36, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 10:18 PM, Timothy Arceri wrote: On 20/10/17 03:31, Iago Toral Quiroga wrote: The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 10:18 PM, Timothy Arceri wrote: > > > On 20/10/17 03:31, Iago Toral Quiroga wrote: >> >> The existing code was checking the whole interface variable rather >> than its members, which is not what we want: we want to check >> aliasing for each member

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 03:31, Iago Toral Quiroga wrote: The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to check aliasing for each member in the interface variable. Surprisingly, there are piglit tests that verify this and were

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:45, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 5:35 PM, Timothy Arceri wrote: On 20/10/17 08:27, Timothy Arceri wrote: On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 5:35 PM, Timothy Arceri wrote: > > > On 20/10/17 08:27, Timothy Arceri wrote: >> >> >> >> On 20/10/17 08:19, Timothy Arceri wrote: >>> >>> On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:27, Timothy Arceri wrote: On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: Will this

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 5:19 PM, Timothy Arceri wrote: > On 20/10/17 04:21, Ilia Mirkin wrote: >> >> On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin >> wrote: >>> >>> On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: Will this work with SSO shaders? Presumably the

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: > On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: >> On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: >>> Will this work with SSO shaders? Presumably the validation still has >>> to happen, but

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: > On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: >> Will this work with SSO shaders? Presumably the validation still has >> to happen, but I don't think cross_validate_outputs_to_inputs() will >> end up getting called.

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: > Will this work with SSO shaders? Presumably the validation still has > to happen, but I don't think cross_validate_outputs_to_inputs() will > end up getting called. The piglit tests I mention use SSO so it seems to be working for this. See

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

Will this work with SSO shaders? Presumably the validation still has to happen, but I don't think cross_validate_outputs_to_inputs() will end up getting called. On Thu, Oct 19, 2017 at 12:31 PM, Iago Toral Quiroga wrote: > The existing code was checking the whole interface

[Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to check aliasing for each member in the interface variable. Surprisingly, there are piglit tests that verify this and were passing due to a bug in the existing code: when we