Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-04-02 Thread Emil Velikov
On 22/03/14 00:10, Emil Velikov wrote: > On 19/03/14 01:06, Jonathan Gray wrote: >> On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: >>> On 18/03/14 14:59, Jonathan Gray wrote: Signed-off-by: Jonathan Gray --- >>> Hi Jonathan >>> >>> While the summary covers what the patch d

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-22 Thread Emil Velikov
On 22/03/14 11:54, Jonathan Gray wrote: > On Sat, Mar 22, 2014 at 11:45:35AM +, Emil Velikov wrote: >> On 22/03/14 04:05, Jonathan Gray wrote: >>> On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote: On 19/03/14 01:06, Jonathan Gray wrote: > On Tue, Mar 18, 2014 at 07:56:21PM

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-22 Thread Jonathan Gray
On Sat, Mar 22, 2014 at 11:45:35AM +, Emil Velikov wrote: > On 22/03/14 04:05, Jonathan Gray wrote: > > On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote: > >> On 19/03/14 01:06, Jonathan Gray wrote: > >>> On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: > On 18/03/

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-22 Thread Emil Velikov
On 22/03/14 04:05, Jonathan Gray wrote: > On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote: >> On 19/03/14 01:06, Jonathan Gray wrote: >>> On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: On 18/03/14 14:59, Jonathan Gray wrote: > Signed-off-by: Jonathan Gray >

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-21 Thread Jonathan Gray
On Sat, Mar 22, 2014 at 03:05:41PM +1100, Jonathan Gray wrote: > On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote: > > On 19/03/14 01:06, Jonathan Gray wrote: > > > On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: > > >> On 18/03/14 14:59, Jonathan Gray wrote: > > >>> Signe

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-21 Thread Jonathan Gray
On Sat, Mar 22, 2014 at 12:10:26AM +, Emil Velikov wrote: > On 19/03/14 01:06, Jonathan Gray wrote: > > On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: > >> On 18/03/14 14:59, Jonathan Gray wrote: > >>> Signed-off-by: Jonathan Gray > >>> --- > >> Hi Jonathan > >> > >> While the s

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-21 Thread Emil Velikov
On 19/03/14 01:06, Jonathan Gray wrote: > On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: >> On 18/03/14 14:59, Jonathan Gray wrote: >>> Signed-off-by: Jonathan Gray >>> --- >> Hi Jonathan >> >> While the summary covers what the patch does, the *ahem* commit message >> fails to expla

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-18 Thread Jonathan Gray
On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: > On 18/03/14 14:59, Jonathan Gray wrote: > > Signed-off-by: Jonathan Gray > > --- > Hi Jonathan > > While the summary covers what the patch does, the *ahem* commit message > fails to explain why it's needed. AFAICS this will cause som

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-18 Thread Emil Velikov
On 18/03/14 14:59, Jonathan Gray wrote: > Signed-off-by: Jonathan Gray > --- Hi Jonathan While the summary covers what the patch does, the *ahem* commit message fails to explain why it's needed. AFAICS this will cause some very nasty breakage in some cases, which we want to avoid without a valid

[Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-03-18 Thread Jonathan Gray
Signed-off-by: Jonathan Gray --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/loader/loader.c src/loader/loader.c index caeeebf..1744acb 100644 --- src/loader/loader.c +++ src/loader/loader.c @@ -202,7 +202,7 @@ out: return (*chip_id >= 0); } -#