Re: [Mesa-dev] [PATCH 2/4] spirv: Use nir_imm_floatN_t for constants for GLSL450 builtins

2018-04-17 Thread Jason Ekstrand
Thanks! 1 and 2 are Reviewed-by: Jason Ekstrand On Wed, Mar 21, 2018 at 12:34 PM, Neil Roberts wrote: > There is an existing macro that is used to choose between either a > float or a double immediate constant based on the bit size of the > first

[Mesa-dev] [PATCH 2/4] spirv: Use nir_imm_floatN_t for constants for GLSL450 builtins

2018-03-21 Thread Neil Roberts
There is an existing macro that is used to choose between either a float or a double immediate constant based on the bit size of the first operand to the builtin. This is now changed to use the new nir_imm_floatN_t helper function to reduce the number of places that make this decision. ---