Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Keith Whitwell
On Mon, 2011-03-21 at 02:12 +0100, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index cf6c5b5..f6ad456 100644 --- a/src/gallium/include/pipe/p_state.h +++ b/src/gallium/include/pipe/p_state.h @@ -81,6 +81,8 @@ struct

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Christoph Bumiller
On 03/21/2011 02:12 AM, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index cf6c5b5..f6ad456 100644 --- a/src/gallium/include/pipe/p_state.h +++ b/src/gallium/include/pipe/p_state.h @@ -81,6 +81,8 @@ struct pipe_rasterizer_state {

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Keith Whitwell
On Mon, 2011-03-21 at 16:23 +0100, Christoph Bumiller wrote: On 03/21/2011 02:12 AM, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index cf6c5b5..f6ad456 100644 --- a/src/gallium/include/pipe/p_state.h +++

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Brian Paul
On 03/21/2011 09:10 AM, Keith Whitwell wrote: On Mon, 2011-03-21 at 02:12 +0100, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index cf6c5b5..f6ad456 100644 --- a/src/gallium/include/pipe/p_state.h +++

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Marek Olšák
Yeah I moved it from the rasterizer state to the blend state, but then I realized the rasterizer state had been a better place. The thing is the fragment color clamping is done right after the fragment shader output is written, that is before the alpha test, before the depth/stencil test, and

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Marek Olšák
On Mon, Mar 21, 2011 at 4:50 PM, Brian Paul bri...@vmware.com wrote: On 03/21/2011 09:10 AM, Keith Whitwell wrote: On Mon, 2011-03-21 at 02:12 +0100, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index cf6c5b5..f6ad456 100644 ---

Re: [Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-21 Thread Christoph Bumiller
On 03/21/2011 05:43 PM, Marek Olšák wrote: On Mon, Mar 21, 2011 at 4:50 PM, Brian Paul bri...@vmware.com wrote: On 03/21/2011 09:10 AM, Keith Whitwell wrote: On Mon, 2011-03-21 at 02:12 +0100, Marek Olšák wrote: diff --git a/src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

2011-03-20 Thread Marek Olšák
From: Luca Barbieri l...@luca-barbieri.com BTW this changes the gallium interface. Some rather cosmetic changes by Marek. Squashed commit of the following: commit 513b37d484f0318311e84bb86ed4c93cdff71f13 Author: Luca Barbieri l...@luca-barbieri.com Date: Thu Aug 26 18:17:54 2010 +0200