Re: [Mesa-dev] [PATCH 2/8] panfrost: Detect GPU version at runtime

2019-03-04 Thread Alyssa Rosenzweig
> "is_t6xx" is not going to scale. We need to do feature and issues. > Doesn't have to be in this series though. Indeed, that's not my concern for this particular series. On that note, I suppose it doesn't matter right now; we only advertise out-of-the-box support for T860 so it doesn't matter if

Re: [Mesa-dev] [PATCH 2/8] panfrost: Detect GPU version at runtime

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 1:35 PM Alyssa Rosenzweig wrote: > > > /* If set, we'll require the use of single render-target framebuffer > > * descriptors (SFBD), for older hardware -- specifically, > If > > This require_sfbd field should also be set at the same time. In > particular, we'll want a

Re: [Mesa-dev] [PATCH 2/8] panfrost: Detect GPU version at runtime

2019-03-04 Thread Alyssa Rosenzweig
> /* If set, we'll require the use of single render-target framebuffer > * descriptors (SFBD), for older hardware -- specifically, +ctx->is_t6xx = pscreen->driver->query_gpu_version(pscreen) == 0x0750; Where did this magic number come from? Is that for T760 or actually T600 or

[Mesa-dev] [PATCH 2/8] panfrost: Detect GPU version at runtime

2019-03-04 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 19 +-- src/gallium/drivers/panfrost/pan_context.h | 3 +++ src/gallium/drivers/panfrost/pan_screen.h | 1 + 3 files changed, 13 insertions(+), 10 deletions(-) diff --git