Re: [Mesa-dev] [PATCH 22/26] python: Use open(), not file()

2018-07-05 Thread Eric Engestrom
On Thursday, 2018-07-05 15:17:53 +0200, Mathieu Bridon wrote: > The latter is a constructor for file objects, but when actually opening > a file, using the former is more idiomatic. > > In addition, file() is not a builtin any more in Python 3, so this makes > the script compatible with both

Re: [Mesa-dev] [PATCH 22/26] python: Use open(), not file()

2018-07-05 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:53) > The latter is a constructor for file objects, but when actually opening > a file, using the former is more idiomatic. > > In addition, file() is not a builtin any more in Python 3, so this makes > the script compatible with

[Mesa-dev] [PATCH 22/26] python: Use open(), not file()

2018-07-05 Thread Mathieu Bridon
The latter is a constructor for file objects, but when actually opening a file, using the former is more idiomatic. In addition, file() is not a builtin any more in Python 3, so this makes the script compatible with both Python 2 and Python 3. Signed-off-by: Mathieu Bridon ---