subject:"\[Mesa\-dev\] \[PATCH 3\/4\] mesa\/main\: fix gl_buffer_index enum comparison"

Re: [Mesa-dev] [PATCH 3/4] mesa/main: fix gl_buffer_index enum comparison

2017-05-31 Thread Samuel Pitoiset

Would be nice to update read_buffer_enum_to_index() and _ColorReadBufferIndex too. On 05/30/2017 10:47 PM, Rob Herring wrote: For clang, enums are unsigned by default and gives the following warning: external/mesa3d/src/mesa/main/buffers.c:764:21: warning: comparison of constant -1 with

Re: [Mesa-dev] [PATCH 3/4] mesa/main: fix gl_buffer_index enum comparison

2017-05-30 Thread Ian Romanick

This patch is Reviewed-by: Ian Romanick On 05/30/2017 01:47 PM, Rob Herring wrote: > For clang, enums are unsigned by default and gives the following warning: > > external/mesa3d/src/mesa/main/buffers.c:764:21: warning: comparison of > constant -1 with expression of

[Mesa-dev] [PATCH 3/4] mesa/main: fix gl_buffer_index enum comparison

2017-05-30 Thread Rob Herring

For clang, enums are unsigned by default and gives the following warning: external/mesa3d/src/mesa/main/buffers.c:764:21: warning: comparison of constant -1 with expression of type 'gl_buffer_index' is always false [-Wtautological-constant-out-of-range-compare] if (srcBuffer == -1) {