Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-05 Thread Andres Gomez
On Fri, 2016-08-05 at 08:35 +1000, Timothy Arceri wrote: > Thanks for you patience with this series :)  The parameter check above The other way around, thanks to you for reviewing! ☺ > is a nice cleanup too thanks. Patches 2 and 3 are: > > Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-04 Thread Timothy Arceri
On Thu, 2016-08-04 at 23:55 +0300, Andres Gomez wrote: > When an argument for a structure constructor or initializer doesn't > match the expected type, only Section 4.1.10 “Implicit Conversions” > are allowed to try to match that expected type. > > From page 32 (page 38 of the PDF) of the GLSL

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-04 Thread Andres Gomez
When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. From page 32 (page 38 of the PDF) of the GLSL 1.20 spec: " The arguments to the constructor will be used to

Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-03 Thread Timothy Arceri
On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > When an argument for a structure constructor or initializer doesn't > match the expected type, only Section 4.1.10 “Implicit Conversions” > are allowed to try to match that expected type. > > From page 32 (page 38 of the PDF) of the GLSL

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-03 Thread Andres Gomez
When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. From page 32 (page 38 of the PDF) of the GLSL 1.20 spec: " The arguments to the constructor will be used to