[Mesa-dev] [PATCH 3/5] i965/fs: Add support for textureGather(.., comp)

2013-10-05 Thread Chris Forbes
- For HSW: Select the channel based on the component selected (swizzle is done in HW) - For IVB: Select the channel based on the swizzle state for the component selected. Only apply the RG32F w/a if we actually want green -- we're about to flag it regardless of swizzle state. Signed-off-by:

Re: [Mesa-dev] [PATCH 3/5] i965/fs: Add support for textureGather(.., comp)

2013-10-05 Thread Kenneth Graunke
On 10/05/2013 03:38 AM, Chris Forbes wrote: - For HSW: Select the channel based on the component selected (swizzle is done in HW) - For IVB: Select the channel based on the swizzle state for the component selected. Only apply the RG32F w/a if we actually want green -- we're about to

Re: [Mesa-dev] [PATCH 3/5] i965/fs: Add support for textureGather(.., comp)

2013-10-05 Thread Chris Forbes
I'm not sure about the compile-time error, or how to hack it in -- at ast_to_hir time, function calls haven't been inlined yet, so I think this gets really nasty? Will address it in a follow-up patch though as you suggest. -- Chris On Sun, Oct 6, 2013 at 7:06 AM, Kenneth Graunke