Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-05 Thread Carl Worth
On Wed, Feb 04 2015, Tapani Pälli wrote: > What would you think about changing this to use some defined maximum > size (in MB)? I think for the user size is what matters and it could be > a configurable option, number of items seems a bit vague and hard to > predict (?) Yes, changing over to a

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-05 Thread Eero Tamminen
Hi, On 02/05/2015 01:31 AM, Kenneth Graunke wrote: On Wednesday, February 04, 2015 01:52:57 PM Carl Worth wrote: From: Kristian Høgsberg This code provides for an on-disk cache of objects. Objects are stored and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-byte sequences, (int

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Aras Pranckevicius
On Thu, Feb 5, 2015 at 1:31 AM, Kenneth Graunke wrote: > On Wednesday, February 04, 2015 01:52:57 PM Carl Worth wrote: > > From: Kristian Høgsberg > > > > This code provides for an on-disk cache of objects. Objects are stored > > and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-b

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Tapani Pälli
Hi; On 02/04/2015 11:52 PM, Carl Worth wrote: From: Kristian Høgsberg This code provides for an on-disk cache of objects. Objects are stored and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-byte sequences, (intended to be SHA-1 hashes of something identifying for the content).

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Matt Turner
On Wed, Feb 4, 2015 at 6:04 PM, Carl Worth wrote: > On Wed, Feb 04 2015, Matt Turner wrote: >> Rebase needed. I removed GLSL_SRCDIR a week and a half ago. > > Was this the removal of all those subdir-objects warnings? Thank you! Yes! Just one warning remaining :). >> I don't think it makes a dif

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Carl Worth
On Wed, Feb 04 2015, Matt Turner wrote: > Rebase needed. I removed GLSL_SRCDIR a week and a half ago. Was this the removal of all those subdir-objects warnings? Thank you! > I don't think it makes a difference to autotools, but I think I'd list > cache.h here instead of in LIBGLSL_FILES. Actuall

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Carl Worth
On Wed, Feb 04 2015, Kenneth Graunke wrote: > The cache will need to be much larger than 1024 entries - perhaps by an > order of magnitude. Thanks for the feedback. I had meant to add a comment next to that 1024 in the code along the lines of "This value was chosen arbitrarily. An appropriate valu

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Matt Turner
On Wed, Feb 4, 2015 at 1:52 PM, Carl Worth wrote: > From: Kristian Høgsberg > > This code provides for an on-disk cache of objects. Objects are stored > and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-byte > sequences, (intended to be SHA-1 hashes of something identifying for > t

Re: [Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Kenneth Graunke
On Wednesday, February 04, 2015 01:52:57 PM Carl Worth wrote: > From: Kristian Høgsberg > > This code provides for an on-disk cache of objects. Objects are stored > and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-byte > sequences, (intended to be SHA-1 hashes of something identif

[Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

2015-02-04 Thread Carl Worth
From: Kristian Høgsberg This code provides for an on-disk cache of objects. Objects are stored and retrieved (in ~/.cache/mesa) via names that are arbitrary 20-byte sequences, (intended to be SHA-1 hashes of something identifying for the content). The cache is limited to a maximum number of entr