Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-12-05 Thread Dylan Baker
Quoting Emil Velikov (2017-12-05 07:36:25) > On 4 December 2017 at 23:57, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-23 11:04:34) > >> On 20 November 2017 at 23:12, Dylan Baker wrote: > >> > This doesn't actually accomplish what it's meant to

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-12-05 Thread Emil Velikov
On 4 December 2017 at 23:57, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-23 11:04:34) >> On 20 November 2017 at 23:12, Dylan Baker wrote: >> > This doesn't actually accomplish what it's meant to do, as extern C >> > doesn't undefine __cplusplus,

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-12-04 Thread Dylan Baker
Quoting Emil Velikov (2017-11-23 11:04:34) > On 20 November 2017 at 23:12, Dylan Baker wrote: > > This doesn't actually accomplish what it's meant to do, as extern C > > doesn't undefine __cplusplus, so the included headers define a template > > (because __cplusplus is

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-11-23 Thread Dylan Baker
Quoting Emil Velikov (2017-11-23 11:04:34) > On 20 November 2017 at 23:12, Dylan Baker wrote: > > This doesn't actually accomplish what it's meant to do, as extern C > > doesn't undefine __cplusplus, so the included headers define a template > > (because __cplusplus is

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-11-23 Thread Emil Velikov
On 20 November 2017 at 23:12, Dylan Baker wrote: > This doesn't actually accomplish what it's meant to do, as extern C > doesn't undefine __cplusplus, so the included headers define a template > (because __cplusplus is defined), but then that code is in an 'extern > "C"'

[Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

2017-11-20 Thread Dylan Baker
This doesn't actually accomplish what it's meant to do, as extern C doesn't undefine __cplusplus, so the included headers define a template (because __cplusplus is defined), but then that code is in an 'extern "C"' block, and explosion. Signed-off-by: Dylan Baker ---