Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-10-24 09:32:07) > On Wed, 2018-10-24 at 09:16 -0700, Dylan Baker wrote: > > Quoting Juan A. Suarez Romero (2018-10-24 09:10:37) > > > On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > > > > There are two problems with the fixed patch. First, it fails to

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Juan A. Suarez Romero
On Wed, 2018-10-24 at 09:16 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-10-24 09:10:37) > > On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > > > There are two problems with the fixed patch. First, it fails to create a > > > dependency on the sourced .c file, so changes

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-10-24 09:10:37) > On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > > There are two problems with the fixed patch. First, it fails to create a > > dependency on the sourced .c file, so changes to intel_tiled_memcpy.c > > won't trigger a rebuild. It also

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > There are two problems with the fixed patch. First, it fails to create a > dependency on the sourced .c file, so changes to intel_tiled_memcpy.c > won't trigger a rebuild. It also doesn't get included in the dist > tarball. > > CC: Tapani

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-23 Thread Tapani Pälli
Thanks for fixing these issues; Reviewed-by: Tapani Pälli On 10/24/18 1:56 AM, Dylan Baker wrote: There are two problems with the fixed patch. First, it fails to create a dependency on the sourced .c file, so changes to intel_tiled_memcpy.c won't trigger a rebuild. It also doesn't get

[Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-23 Thread Dylan Baker
There are two problems with the fixed patch. First, it fails to create a dependency on the sourced .c file, so changes to intel_tiled_memcpy.c won't trigger a rebuild. It also doesn't get included in the dist tarball. CC: Tapani Pälli Fixes: 11b1afdc92db98e93f2ca50beeb7fc481a11e708