Re: [Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

2017-04-21 Thread Samuel Pitoiset
On 04/21/2017 11:47 AM, Timothy Arceri wrote: On 21/04/17 17:50, Samuel Pitoiset wrote: I would definitely prefer to see _mesa_hash_table instead here. That way you can get rid of the unnecessary locking at the same time. I actually use _mesa_hash_table for the resident texture/image

Re: [Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

2017-04-21 Thread Timothy Arceri
On 21/04/17 17:50, Samuel Pitoiset wrote: I would definitely prefer to see _mesa_hash_table instead here. That way you can get rid of the unnecessary locking at the same time. I actually use _mesa_hash_table for the resident texture/image handles as part of ARB_bindless_texture. Though, I use

Re: [Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

2017-04-21 Thread Nicolai Hähnle
On 21.04.2017 07:20, Timothy Arceri wrote: From Chapter 5 'Shared Objects and Multiple Contexts' of the OpenGL 4.5 spec: "Objects which contain references to other objects include framebuffer, program pipeline, query, transform feedback, and vertex array objects. Such objects are

Re: [Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

2017-04-21 Thread Samuel Pitoiset
I would definitely prefer to see _mesa_hash_table instead here. That way you can get rid of the unnecessary locking at the same time. I actually use _mesa_hash_table for the resident texture/image handles as part of ARB_bindless_texture. Though, I use the locked hash_table implementation

[Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

2017-04-20 Thread Timothy Arceri
From Chapter 5 'Shared Objects and Multiple Contexts' of the OpenGL 4.5 spec: "Objects which contain references to other objects include framebuffer, program pipeline, query, transform feedback, and vertex array objects. Such objects are called container objects and are not shared"