Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 3:32 PM, Rowley, Timothy O wrote: > Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave > the changes as they are, then. > > This series of four patches (or rather, the rebased versions in your repo) > are Reviewed-by: Tim Rowley Thanks, pushed! Yo

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Rowley, Timothy O
Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave the changes as they are, then. This series of four patches (or rather, the rebased versions in your repo) are Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Nov 23, 2016, at 2:11 PM, Ilia Mirkin mailto

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 3:02 PM, Rowley, Timothy O wrote: > This code seems to assume that all attached buffers have the same start > layer, and that start will be zero. Maybe it should construct the clearMask > inside the layer loop, which would also be a bit clearer than the code you > added

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Rowley, Timothy O
This code seems to assume that all attached buffers have the same start layer, and that start will be zero. Maybe it should construct the clearMask inside the layer loop, which would also be a bit clearer than the code you added to drop bits out of the mask? -Tim > On Nov 17, 2016, at 6:51 PM

[Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- With this patch, the layered-rendering clear tests pass, both with fast clear enabled and disabled. src/gallium/drivers/swr/swr_clear.cpp | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/s