Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-24 Thread Jose Fonseca
On 24/01/17 13:11, Emil Velikov wrote: On 23 January 2017 at 19:39, Tobias Droste wrote: Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: On 20/01/17 02:48, Emil Velikov wrote: On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18.

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-24 Thread Emil Velikov
On 23 January 2017 at 19:39, Tobias Droste wrote: > Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: >> On 20/01/17 02:48, Emil Velikov wrote: >> > On 19 January 2017 at 19:26, Tobias Droste wrote: >> >> Am Mittwoch, 18. Januar 2017, 18:45:04 CET

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Roland Scheidegger
Am 23.01.2017 um 20:39 schrieb Tobias Droste: > Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: >> On 20/01/17 02:48, Emil Velikov wrote: >>> On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov:

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Tobias Droste
Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: > On 20/01/17 02:48, Emil Velikov wrote: > > On 19 January 2017 at 19:26, Tobias Droste wrote: > >> Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > >>> On 18 January 2017 at 18:12, Jose Fonseca

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Jose Fonseca
On 20/01/17 02:48, Emil Velikov wrote: On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: On 18 January 2017 at 18:12, Jose Fonseca wrote: In order to untangle things we want to have a

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-19 Thread Emil Velikov
On 19 January 2017 at 19:26, Tobias Droste wrote: > Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: >> On 18 January 2017 at 18:12, Jose Fonseca wrote: >> >>> In order to untangle things we want to have a distinction between the >> >>>

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-19 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > On 18 January 2017 at 18:12, Jose Fonseca wrote: > >>> In order to untangle things we want to have a distinction between the > >>> gallium (gallivm afaict) and other users - RADV presently. > >>> So how about

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 18:12, Jose Fonseca wrote: >>> In order to untangle things we want to have a distinction between the >>> gallium (gallivm afaict) and other users - RADV presently. >>> So how about we update the RADV instances and ensure that the we set >>> the

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Mit freundlichen Grüßen Tobias Droste Am Mittwoch, 18. Januar 2017, 18:12:37 CET schrieb Jose Fonseca: > On 18/01/17 17:51, Tobias Droste wrote: > > Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > >> On 18 January 2017 at 15:11, Jose Fonseca wrote: > >>>

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
On 18/01/17 17:51, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: On 18 January 2017 at 15:11, Jose Fonseca wrote: I've reverted this and took a closer look. I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > On 18 January 2017 at 15:11, Jose Fonseca wrote: > > I've reverted this and took a closer look. > > > > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM > > and what not. > > > >

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 15:11, Jose Fonseca wrote: > I've reverted this and took a closer look. > > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM > and what not. > > But I'm afraid I can't accept replacing HAVE_LLVM in the .c code, because: > - it

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
I've reverted this and took a closer look. I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM and what not. But I'm afraid I can't accept replacing HAVE_LLVM in the .c code, because: - it breaks the other build systems if not updated - but above all, it creates merge

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
This change was commited and completely broke scons build. It's also the first time I see HAVE_GALLIUM_LLVM name. I don't mind if people fiddle with autoconf and break it as much as they want, but please don't fiddle with gallium/llvmpipe .C code without me or Roland's review or acked by.

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2016-12-16 Thread Tobias Droste
Hey Emil, did you have to time look at this? What should we do? I would argue to first merge what I have now and if you really want to disallow llvm-less gallium with llvm-full radv we could do this later and revert the changes of patch 4. Personally I think it's ok how it is now. Gallium

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2016-12-08 Thread Tobias Droste
Am Donnerstag, 8. Dezember 2016, 17:14:12 CET schrieb Emil Velikov: > On 8 December 2016 at 02:03, Tobias Droste wrote: > > Gallium code used HAVE_LLVM to check if it needs to compile code for > > LLVM in header and source files. > > > > With the new logic HAVE_LLVM is always

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2016-12-08 Thread Emil Velikov
On 8 December 2016 at 02:03, Tobias Droste wrote: > Gallium code used HAVE_LLVM to check if it needs to compile code for > LLVM in header and source files. > > With the new logic HAVE_LLVM is always set. Use extra define to figure > out if LLVM is used. > > Bugzilla:

[Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2016-12-07 Thread Tobias Droste
Gallium code used HAVE_LLVM to check if it needs to compile code for LLVM in header and source files. With the new logic HAVE_LLVM is always set. Use extra define to figure out if LLVM is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99010 Signed-off-by: Tobias Droste