Hi,
> This is in fact two changes: introduction of the helpers and refactoring of
> the intersection code to be used with caller provided bounding box.
Is this a request to change the commit message or to split this as well?
I think splitting it is silly, but if it make you happy so be it; the
On Fri, Apr 24, 2015 at 09:59:07AM +0300, kevin.rogo...@intel.com wrote:
> From: Kevin Rogovin
>
> To assist drivers to implement ARB_framebuffer_no_attachment, provide
> a set of convenience functions that check for gl_framebuffer::_HasAttachments
> that return the geometry of the gl_framebuffer
Functionally correct, style nitpicks below, with those fixed;
Reviewed-by: Tapani Pälli
On 04/24/2015 09:59 AM, kevin.rogo...@intel.com wrote:
From: Kevin Rogovin
To assist drivers to implement ARB_framebuffer_no_attachment, provide
a set of convenience functions that check for gl_framebuffe
From: Kevin Rogovin
To assist drivers to implement ARB_framebuffer_no_attachment, provide
a set of convenience functions that check for gl_framebuffer::_HasAttachments
that return the geometry of the gl_framebuffer.
---
src/mesa/main/framebuffer.c | 49 ++