Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-09-07 Thread Francisco Jerez
Jason Ekstrand writes: > On Wed, Sep 6, 2017 at 3:58 PM, Chema Casanova > wrote: > >> Hi Connor and Curro, >> >> On 28/08/17 12:24, Alejandro Piñeiro wrote: >> > On 27/08/17 20:24, Connor Abbott wrote: >> >> Hi, >> >> >> >> On Aug 25, 2017 9:28 AM,

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-09-07 Thread Jason Ekstrand
On Wed, Sep 6, 2017 at 3:58 PM, Chema Casanova wrote: > Hi Connor and Curro, > > On 28/08/17 12:24, Alejandro Piñeiro wrote: > > On 27/08/17 20:24, Connor Abbott wrote: > >> Hi, > >> > >> On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" >>

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-09-06 Thread Chema Casanova
Hi Connor and Curro, On 28/08/17 12:24, Alejandro Piñeiro wrote: > On 27/08/17 20:24, Connor Abbott wrote: >> Hi, >> >> On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" > > wrote: >> >> On 24/08/17 21:07, Connor Abbott wrote: >> > >> >

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-28 Thread Alejandro Piñeiro
On 27/08/17 20:24, Connor Abbott wrote: > Hi, > > On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" > wrote: > > On 24/08/17 21:07, Connor Abbott wrote: > > > > Hi Alejandro, > > Hi Connor, > > > > > This seems really

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-27 Thread Connor Abbott
Hi, On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" wrote: On 24/08/17 21:07, Connor Abbott wrote: > > Hi Alejandro, Hi Connor, > > This seems really suspicious. If the live ranges are really > independent, then the register allocator should be able to assign the > two

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-25 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 24/08/17 21:07, Connor Abbott wrote: >> >> Hi Alejandro, > > Hi Connor, > >> >> This seems really suspicious. If the live ranges are really >> independent, then the register allocator should be able to assign the >> two virtual registers to

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-25 Thread Alejandro Piñeiro
On 24/08/17 21:07, Connor Abbott wrote: > > Hi Alejandro, Hi Connor, > > This seems really suspicious. If the live ranges are really > independent, then the register allocator should be able to assign the > two virtual registers to the same physical register if it needs to. Yes, it is true, the

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-24 Thread Connor Abbott
Hi Alejandro, This seems really suspicious. If the live ranges are really independent, then the register allocator should be able to assign the two virtual registers to the same physical register if it needs to. This change forces the two to be the same, which constrains the register allocator

[Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

2017-08-24 Thread Alejandro Piñeiro
When dealing with HF/U/UW, it is usual having a register with a F/D/UD, and then convert it to HF/U/UW, and not use again the F/D/UD value. In those cases it would be possible to reuse the register where the F value is initially stored instead of having two. Take also into account that when