Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-08-13 Thread Matt Arsenault
On Jun 26, 2014, at 7:15 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Tom Stellard
On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-04 Thread Tom Stellard
On Fri, Jul 04, 2014 at 05:25:42PM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:05PM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Tom Stellard
On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Tom Stellard
On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-02 Thread Tom Stellard
On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-02 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-06-26 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device

[Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-06-25 Thread Tom Stellard
v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to has_doubles().

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Matt Arsenault
On Jun 21, 2014, at 9:37 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard thomas.stell...@amd.com writes: --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- src/gallium/state_trackers/clover/core/device.cpp | 6 ++

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Francisco Jerez
Matt Arsenault arse...@gmail.com writes: On Jun 21, 2014, at 9:37 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard thomas.stell...@amd.com writes: [...] case CL_DEVICE_EXTENSIONS: - buf.as_string() = ; + // The trailing space is intentional. It is a spec-ism that

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-21 Thread Matt Arsenault
On Jun 21, 2014, at 12:32 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Arsenault arse...@gmail.com writes: On Jun 21, 2014, at 9:37 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard thomas.stell...@amd.com writes: [...] case CL_DEVICE_EXTENSIONS: -

[Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-17 Thread Tom Stellard
--- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-17 Thread Bruno Jimenez
Hi, I have a couple of questions about this patch: 1) Could you please also change how the results of the 'CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE' and 'CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE' queries are generated? According to the spec, if 'cl_khr_fp64' is not supported, they should be 0. 2)

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

2014-06-17 Thread Matt Arsenault
On Jun 17, 2014, at 3:11 PM, Bruno Jimenez brunoji...@gmail.com wrote: Hi, I have a couple of questions about this patch: 1) Could you please also change how the results of the 'CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE' and 'CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE' queries are generated?