[Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

2015-12-14 Thread Samuel Pitoiset
frame cannot be NULL in that branch. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_video.c

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

2015-12-14 Thread Ilia Mirkin
This code is old, crusty and subtle. Clearly this can't happen, however I'd rather not remove it... if you really hate it how about a #if 0 /* XXX */ ... #endif I have no idea what DUAL_PRIME is, or whether it appears for frame or field stuff. Or what that PMPEG command does for that matter. On

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

2015-12-14 Thread Pierre Moreau
On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: > frame cannot be NULL in that branch. Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nouveau_video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

2015-12-14 Thread Samuel Pitoiset
On 12/14/2015 04:48 PM, Pierre Moreau wrote: On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: frame cannot be NULL in that branch. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2