Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-21 Thread Christian König
Am 18.01.2013 20:29, schrieb Marek Olšák: On Fri, Jan 18, 2013 at 5:20 PM, Christian König deathsim...@vodafone.de wrote: Am 18.01.2013 16:40, schrieb Marek Olšák: [SNIP] Having common base classes for all three radeon drivers sounds like a good idea to me and sharing the texture code between

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Christian König
Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: Forking r600g was obviously a bad idea, because now radeonsi is

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Marek Olšák
On Fri, Jan 18, 2013 at 2:46 PM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: On Don, 2013-01-17 at 17:56 +0100,

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Alex Deucher
On Fri, Jan 18, 2013 at 10:40 AM, Marek Olšák mar...@gmail.com wrote: On Fri, Jan 18, 2013 at 2:46 PM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-01-17 at

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Alex Deucher
On Fri, Jan 18, 2013 at 10:45 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Fri, Jan 18, 2013 at 10:40 AM, Marek Olšák mar...@gmail.com wrote: On Fri, Jan 18, 2013 at 2:46 PM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Christian König
Am 18.01.2013 16:40, schrieb Marek Olšák: On Fri, Jan 18, 2013 at 2:46 PM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-18 Thread Marek Olšák
On Fri, Jan 18, 2013 at 5:20 PM, Christian König deathsim...@vodafone.de wrote: Am 18.01.2013 16:40, schrieb Marek Olšák: On Fri, Jan 18, 2013 at 2:46 PM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2013 23:54, schrieb Alex Deucher: On Thu, Jan 17, 2013 at 12:32 PM, Michel

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Marek Olšák
This is a pretty ugly hack. It won't work if a depth texture is set in a fragment shader and a non-depth texture is later set in a vertex shader. That will cause have_depth_texture to be false. The proper solution is to port the depth-texture tracking from r600g, well, ideally the whole

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Michel Dänzer
On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: This is a pretty ugly hack. It won't work if a depth texture is set in a fragment shader and a non-depth texture is later set in a vertex shader. That will cause have_depth_texture to be false. The proper solution is to port the

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Michel Dänzer
On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: Forking r600g was obviously a bad idea, because now radeonsi is just as horrible as r600g used to be. What do you suggest? That's an honest question, BTW. It's certainly

Re: [Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-17 Thread Alex Deucher
On Thu, Jan 17, 2013 at 12:32 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-01-17 at 18:02 +0100, Michel Dänzer wrote: On Don, 2013-01-17 at 17:56 +0100, Marek Olšák wrote: Forking r600g was obviously a bad idea, because now radeonsi is just as horrible as r600g used to be. What

[Mesa-dev] [PATCH 6/6] radeonsi: Actually keep track if we are using depth textures for samplers.

2013-01-16 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 20-odd more piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c