Re: [Mesa-dev] [PATCH 6/9] i965: Use _mesa_geometry_ functions appropriately

2015-04-29 Thread Rogovin, Kevin
Hi, One comment on the code, or rather a request to the reviewer of the code. The icky part of checking this patch is correct is checking that the remaining instances of gl_framebuffer::Width, Height, MaxNumLayers and Visaul.samples are "correct". I believe I "got 'em all", of those that shoul

[Mesa-dev] [PATCH 6/9] i965: Use _mesa_geometry_ functions appropriately

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection of the attachments of the