Re: [Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

2017-08-28 Thread Jason Ekstrand
On Mon, Aug 28, 2017 at 2:50 PM, Matt Turner wrote: > On Mon, Aug 28, 2017 at 7:51 AM, Jason Ekstrand > wrote: > > The readInvocationARB built-in maps fairly nicely to our BROADCAST > > opcode. However, the current implementation isn't quite right.

Re: [Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

2017-08-28 Thread Matt Turner
On Mon, Aug 28, 2017 at 7:51 AM, Jason Ekstrand wrote: > The readInvocationARB built-in maps fairly nicely to our BROADCAST > opcode. However, the current implementation isn't quite right. This > commit fixes three different issues: > > 1) It was blindly taking component

[Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

2017-08-28 Thread Jason Ekstrand
The readInvocationARB built-in maps fairly nicely to our BROADCAST opcode. However, the current implementation isn't quite right. This commit fixes three different issues: 1) It was blindly taking component 0 of the index value even if that channel is disabled. We need emit_uniformize()