Re: [Mesa-dev] [PATCH 7/8] glsl: stop adding pointers from shader_info to the cache

2017-08-22 Thread Timothy Arceri
On 22/08/17 03:19, Samuel Pitoiset wrote: Looks like you no longer encode shader_info::stage (which is the first field), is that expected? Nice catch! I guess we probably don't use this field after compilation, although we should still fix it so I've sent a 6.5 patch to reorder the members.

Re: [Mesa-dev] [PATCH 7/8] glsl: stop adding pointers from shader_info to the cache

2017-08-21 Thread Samuel Pitoiset
Looks like you no longer encode shader_info::stage (which is the first field), is that expected? On 08/14/2017 01:49 AM, Timothy Arceri wrote: This is so we always create reproducible cache entries. Consistency is required for verification of any third party distributed shaders. --- src/compi